Certainly better than doing nothing, although there will be issues that will be difficult to control completely. In most places there is a black market of sorts for cigs and laws like this will push some to that market. In terms of kids starting smoking, it's my understanding that Vape is the go-to more so than cigs. There seems to be a belief that it's safer health wise and it's marketed in such a manner to attract the youger crowd and I think it will be challenging to have an effective ban on vaping products. Hopefully they'll work things out over time.
I expect many more countries will follow with similar legislation.